CMake: Fix missing librt target #5056
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building the static SDK, dispatch is built as a static archive, so
it's dependency on librt is exposed as part of its link interface.
This shows up in the `dispatchConfig.cmake` file imported by
`find_package(dispatch CONFIG)`.
```
CMake Error at build/x86_64/dispatch/cmake/modules/dispatchExports.cmake:71 (set_target_properties):
The link interface of target "dispatch" contains:
RT::rt
but the target was not found. Possible reasons include:
* There is a typo in the target name.
* A find_package call is missing for an IMPORTED target.
* An ALIAS target is missing.
```
It would be great if the dispatch config could include that target to
ensure that everyone is using the same librt, it does not, so we have to
find and include it ourselves.
|
@swift-ci please test |
|
(There are more failures in the static SDK builds, figured I'd put this one up for now.) |
jmschonfeld
reviewed
Aug 7, 2024
| @@ -93,6 +93,7 @@ if(NOT SwiftFoundation_MODULE_TRIPLE) | |||
| endif() | |||
|
|
|||
| # System dependencies | |||
| find_package(LibRT) | |||
There was a problem hiding this comment.
For my context, is there a reason that's preventing us from fixing this on the dispatch side instead of applying a workaround to Foundation (and presumably any other project that imports dispatch via CMake in the toolchain)? Is there a way we can just add this to the exported config for dispatch?
|
This will be fixed as part of #5069. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the static SDK, dispatch is built as a static archive, so its dependency on librt is exposed as part of its link interface. This shows up in the
dispatchConfig.cmakefile imported byfind_package(dispatch CONFIG).It would be great if the dispatch config could include that target to ensure that everyone is using the same librt, it does not, so we have to find and include it ourselves.